refactor workflows #5552
Merged
refactor workflows #5552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-deep-learning-containers-ci
bot
added
authorized
Size:XL
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Junpu Fan <[email protected]>
Signed-off-by: Junpu Fan <[email protected]>
Signed-off-by: Junpu Fan <[email protected]>
Signed-off-by: Junpu Fan <[email protected]>
Signed-off-by: Junpu Fan <[email protected]>
Signed-off-by: Junpu Fan <[email protected]>
Signed-off-by: Junpu Fan <[email protected]>
sirutBuasai
reviewed
Dec 15, 2025
| echo "IMAGE_URI=${IMAGE_URI}" >> ${GITHUB_OUTPUT} | ||
| sglang-local-benchmark-test: | ||
| needs: [set-test-environment, build-sglang-image] |
Member
There was a problem hiding this comment.
This change means that we will test local-benchmark-test on prod image if the build didn't happen btw. Do we want to always run the test?
My thought process for implementing it this way was that al these upstream tests only need to run if we're building a new image. If we're using a prod image, then we can assume that these tests passed
Contributor
Author
There was a problem hiding this comment.
Hmm, make sense to me, i can add it back
sirutBuasai
reviewed
Dec 15, 2025
Member
There was a problem hiding this comment.
do we want to organize the env part to be the same format as pr-vllm file?
Contributor
Author
There was a problem hiding this comment.
probably not necessary at this point, we can keep that free form for now
Signed-off-by: Junpu Fan <[email protected]>
sirutBuasai
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.